Skip to content

docs(langflow): sync template standards updates#348

Merged
mberlofa merged 3 commits into
mainfrom
docs/langflow-template-standards-sync
Jul 6, 2026
Merged

docs(langflow): sync template standards updates#348
mberlofa merged 3 commits into
mainfrom
docs/langflow-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Sync Langflow chart docs with the NetworkPolicy egress behavior from fix(langflow): align template standards charts#670.
  • Document networkPolicy.dnsEgressPeers and the default kube-system/kube-dns DNS peer selection.
  • Add Langflow Network Policy controls to the playground config.

Related

Validation

  • make site-sync-check CHART=langflow
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Summary by CodeRabbit

  • New Features
    • Added Langflow to the playground chart selection.
    • Introduced new network policy settings, including DNS egress controls and extra egress CIDR/port options.
  • Bug Fixes
    • Improved the Olivetin ingress class dropdown with an empty option and reordered choices.
  • Documentation
    • Updated Langflow chart documentation with the pinned image version and expanded guidance on core environment variables, persistence behavior, ingress class handling, and network policy examples (including DNS egress peers).

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Updates olivetin playground options, adds langflow network policy playground fields, updates langflow documentation, and makes langflow eligible for playground sync.

Changes

Playground configs and docs

Layer / File(s) Summary
Olivetin ingress options
src/data/playground-configs.ts
Updates the ingress class select options to include an empty value and reorder the available controllers.
Langflow playground network policy
src/data/playground-configs.ts
Adds a langflow network policy section with DNS selector fields, an extra egress CIDR field, and an extra egress port field.
Langflow docs and playground sync
src/pages/docs/charts/langflow.mdx, src/pages/playground.astro
Updates the langflow chart documentation for the pinned image, configuration reference, production example, and scaling text, and adds langflow to the playground sync configs list.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • helmforgedev/site#322: Also updates src/pages/playground.astro by extending siteSyncPlaygroundConfigs with another chart slug.
  • helmforgedev/site#330: Also changes src/pages/playground.astro to make a new chart slug eligible for playground filtering.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and relevant to the Langflow docs sync, though it is broader than the specific NetworkPolicy changes.
Description check ✅ Passed The description covers the summary, related change, and validation, but it omits the required Quality Gates checklist section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/langflow-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/data/playground-configs.ts (1)

4493-4550: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Langflow playground entry has no NetworkPolicy field despite doc coverage.

langflow.mdx (same PR) documents networkPolicy.enabled and networkPolicy.extraEgress in detail, and the PR objectives claim NetworkPolicy controls are exposed for Langflow in the playground registry. This langflow config block is unchanged and still only has General and Ingress sections — no NetworkPolicy field group to let users preview/toggle this documented behavior.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/data/playground-configs.ts` around lines 4493 - 4550, The langflow
playground config is missing the documented NetworkPolicy controls, so the
registry entry still only exposes General and Ingress settings. Update the
langflow block in the playground config to add a NetworkPolicy field group
alongside the existing sections, wiring in the same networkPolicy.enabled and
networkPolicy.extraEgress controls described in langflow.mdx so users can
preview and toggle them from the playground.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/data/playground-configs.ts`:
- Around line 4493-4550: The langflow playground config is missing the
documented NetworkPolicy controls, so the registry entry still only exposes
General and Ingress settings. Update the langflow block in the playground config
to add a NetworkPolicy field group alongside the existing sections, wiring in
the same networkPolicy.enabled and networkPolicy.extraEgress controls described
in langflow.mdx so users can preview and toggle them from the playground.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5a9a17a0-ede6-4771-9640-a210e3e815e3

📥 Commits

Reviewing files that changed from the base of the PR and between 365449a and eded28b.

📒 Files selected for processing (3)
  • src/data/playground-configs.ts
  • src/pages/docs/charts/langflow.mdx
  • src/pages/playground.astro

@mberlofa mberlofa force-pushed the docs/langflow-template-standards-sync branch 2 times, most recently from 28633a8 to 487dccd Compare July 4, 2026 12:13
@mberlofa

mberlofa commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the CodeRabbit review-body feedback.

Changes:

  • Moved the misplaced NetworkPolicy egress control out of the OliveTin config area.
  • Consolidated Langflow NetworkPolicy controls under a Network Policy playground group.
  • Added an explicit networkPolicy.enabled toggle plus DNS peer fields and the missing networkPolicy.extraEgress CIDR field, alongside the existing extra egress port control.

Validation:

  • npm run lint passed
  • npm run build passed
  • make site-sync-check CHART=langflow passed
  • make release-check REPO=site passed
  • make attribution-check REPO=site passed
  • git diff --check passed

Note: this CodeRabbit item was posted in the review summary/body, not as an active review thread, so there is no thread ID to reply to or resolve.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/data/playground-configs.ts`:
- Around line 4536-4547: The Network Policy group is binding the same
`networkPolicy.enabled` field twice, once as the collapsible `gateField` and
again as the toggle in the `fields` array. Update the `Network Policy` config
block in `playground-configs.ts` so it uses a single control for
`networkPolicy.enabled`, keeping one source of truth and removing the duplicate
toggle from the section.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6267983e-c6fc-4a75-abfb-a92ef154c609

📥 Commits

Reviewing files that changed from the base of the PR and between 487dccd and c1d19f9.

📒 Files selected for processing (1)
  • src/data/playground-configs.ts

Comment thread src/data/playground-configs.ts Outdated
mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
## Summary
- Align Langflow template standards: immutable selector labels, guarded
ingressClassName, centralized validate helper, and numbered NOTES.
- Make NetworkPolicy egress isolation active whenever
`networkPolicy.enabled=true`, with scoped configurable DNS peers,
built-in HTTPS allowance, and additive `networkPolicy.extraEgress`.
- Sync values schema defaults and validation/unit coverage for
selector-label overrides, existingClaim scaling, and NetworkPolicy
egress behavior.
- Remove hardcoded runtime env hints from NOTES when they can be
overridden by user-provided env entries.

## Related
- Site sync: helmforgedev/site#348.
- Issue: #633.

## Validation
- `helm template test charts/langflow --set networkPolicy.enabled=true |
rg -n "policyTypes|Egress|kube-system|kube-dns|port: 53|port: 443"`
- `helm unittest charts/langflow` (20 tests, 6 suites)
- `make template-standards-check CHART=langflow`
- `node scripts/charts/validate-chart.js --chart langflow --no-k3d`
- `make validate-chart CHART=langflow TIMEOUT=900` (FULLY VALIDATED, 17
layers)
- `make site-sync-check CHART=langflow`
- `make release-check REPO=charts` (expected GR-077 post-merge release
warning)
- `make attribution-check REPO=charts`

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
  * Added `networkPolicy` DNS allow-listing via `dnsEgressPeers`.
* Added `networkPolicy.extraEgress` to append additional outbound rules
after the built-in DNS and HTTPS allowances.
* **Bug Fixes**
  * Improved pod labeling to consistently match selector labels.
  * `ingressClassName` is now omitted when unset or intentionally blank.
* **Documentation**
* Expanded post-install notes with clearer access, runtime/state/auth,
scaling, exposure, and troubleshooting details.
* **Tests**
* Updated and added Helm chart tests for ingress behavior, network
policy egress ordering, and validation rules.
* **Chores**
  * Updated default image tag recommendation to `1.10.1`.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa force-pushed the docs/langflow-template-standards-sync branch from 282c09c to 2708f8a Compare July 6, 2026 13:37
@mberlofa mberlofa merged commit 69643f8 into main Jul 6, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/langflow-template-standards-sync branch July 6, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant