docs(langflow): sync template standards updates#348
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdates olivetin playground options, adds langflow network policy playground fields, updates langflow documentation, and makes langflow eligible for playground sync. ChangesPlayground configs and docs
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/data/playground-configs.ts (1)
4493-4550: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winLangflow playground entry has no NetworkPolicy field despite doc coverage.
langflow.mdx(same PR) documentsnetworkPolicy.enabledandnetworkPolicy.extraEgressin detail, and the PR objectives claim NetworkPolicy controls are exposed for Langflow in the playground registry. Thislangflowconfig block is unchanged and still only hasGeneralandIngresssections — no NetworkPolicy field group to let users preview/toggle this documented behavior.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/data/playground-configs.ts` around lines 4493 - 4550, The langflow playground config is missing the documented NetworkPolicy controls, so the registry entry still only exposes General and Ingress settings. Update the langflow block in the playground config to add a NetworkPolicy field group alongside the existing sections, wiring in the same networkPolicy.enabled and networkPolicy.extraEgress controls described in langflow.mdx so users can preview and toggle them from the playground.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/data/playground-configs.ts`:
- Around line 4493-4550: The langflow playground config is missing the
documented NetworkPolicy controls, so the registry entry still only exposes
General and Ingress settings. Update the langflow block in the playground config
to add a NetworkPolicy field group alongside the existing sections, wiring in
the same networkPolicy.enabled and networkPolicy.extraEgress controls described
in langflow.mdx so users can preview and toggle them from the playground.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5a9a17a0-ede6-4771-9640-a210e3e815e3
📒 Files selected for processing (3)
src/data/playground-configs.tssrc/pages/docs/charts/langflow.mdxsrc/pages/playground.astro
28633a8 to
487dccd
Compare
|
Addressed the CodeRabbit review-body feedback. Changes:
Validation:
Note: this CodeRabbit item was posted in the review summary/body, not as an active review thread, so there is no thread ID to reply to or resolve. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/data/playground-configs.ts`:
- Around line 4536-4547: The Network Policy group is binding the same
`networkPolicy.enabled` field twice, once as the collapsible `gateField` and
again as the toggle in the `fields` array. Update the `Network Policy` config
block in `playground-configs.ts` so it uses a single control for
`networkPolicy.enabled`, keeping one source of truth and removing the duplicate
toggle from the section.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6267983e-c6fc-4a75-abfb-a92ef154c609
📒 Files selected for processing (1)
src/data/playground-configs.ts
## Summary - Align Langflow template standards: immutable selector labels, guarded ingressClassName, centralized validate helper, and numbered NOTES. - Make NetworkPolicy egress isolation active whenever `networkPolicy.enabled=true`, with scoped configurable DNS peers, built-in HTTPS allowance, and additive `networkPolicy.extraEgress`. - Sync values schema defaults and validation/unit coverage for selector-label overrides, existingClaim scaling, and NetworkPolicy egress behavior. - Remove hardcoded runtime env hints from NOTES when they can be overridden by user-provided env entries. ## Related - Site sync: helmforgedev/site#348. - Issue: #633. ## Validation - `helm template test charts/langflow --set networkPolicy.enabled=true | rg -n "policyTypes|Egress|kube-system|kube-dns|port: 53|port: 443"` - `helm unittest charts/langflow` (20 tests, 6 suites) - `make template-standards-check CHART=langflow` - `node scripts/charts/validate-chart.js --chart langflow --no-k3d` - `make validate-chart CHART=langflow TIMEOUT=900` (FULLY VALIDATED, 17 layers) - `make site-sync-check CHART=langflow` - `make release-check REPO=charts` (expected GR-077 post-merge release warning) - `make attribution-check REPO=charts` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added `networkPolicy` DNS allow-listing via `dnsEgressPeers`. * Added `networkPolicy.extraEgress` to append additional outbound rules after the built-in DNS and HTTPS allowances. * **Bug Fixes** * Improved pod labeling to consistently match selector labels. * `ingressClassName` is now omitted when unset or intentionally blank. * **Documentation** * Expanded post-install notes with clearer access, runtime/state/auth, scaling, exposure, and troubleshooting details. * **Tests** * Updated and added Helm chart tests for ingress behavior, network policy egress ordering, and validation rules. * **Chores** * Updated default image tag recommendation to `1.10.1`. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: MergeCheck <mergecheck@example.invalid>
282c09c to
2708f8a
Compare
Summary
networkPolicy.dnsEgressPeersand the default kube-system/kube-dns DNS peer selection.Related
Validation
make site-sync-check CHART=langflownpm run lintnpm run format:checknpm run buildmake release-check REPO=sitemake attribution-check REPO=siteSummary by CodeRabbit